Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support views in BaseShowTablesWithSizes for MySQL 8.0 #13394

Merged
merged 4 commits into from
Jun 28, 2023
Merged

Support views in BaseShowTablesWithSizes for MySQL 8.0 #13394

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c0faafe
Support views in BaseShowTablesWithSizes for MySQL 8.0
shlomi-noach Jun 28, 2023
af31aec
added test
shlomi-noach Jun 28, 2023
a743f84
fixed test
shlomi-noach Jun 28, 2023
e0258ff
schema tracker: use null safe comparison
systay Jun 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions go/mysql/flavor_mysql.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,6 +352,7 @@ GROUP BY t.table_name, t.table_type, t.create_time, t.table_comment`
// - We utilize `INFORMATION_SCHEMA`.`TABLES`.`CREATE_OPTIONS` column to do early pruning before the JOIN.
// - `TABLES`.`TABLE_NAME` has `utf8mb4_0900_ai_ci` collation. `INNODB_TABLESPACES`.`NAME` has `utf8mb3_general_ci`.
// We normalize the collation to get better query performance (we force the casting at the time of our choosing)
// - `create_options` is NULL for views, and therefore we need an additional UNION ALL to include views
const TablesWithSize80 = `SELECT t.table_name,
t.table_type,
UNIX_TIMESTAMP(t.create_time),
Expand All @@ -378,6 +379,16 @@ UNION ALL
t.table_schema = database() AND t.create_options = 'partitioned'
GROUP BY
t.table_schema, t.table_name, t.table_type, t.create_time, t.table_comment
UNION ALL
SELECT t.table_name,
t.table_type,
UNIX_TIMESTAMP(t.create_time),
t.table_comment,
NULL,
NULL
FROM information_schema.tables t
WHERE
t.table_schema = database() AND t.table_type='VIEW'
`

// baseShowTablesWithSizes is part of the Flavor interface.
Expand Down