-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0] Fix: TabletServer ReserveBeginExecute to return transaction ID on error #13193
Merged
harshit-gangal
merged 2 commits into
vitessio:release-16.0
from
planetscale:settingspool-fix
May 30, 2023
Merged
[16.0] Fix: TabletServer ReserveBeginExecute to return transaction ID on error #13193
harshit-gangal
merged 2 commits into
vitessio:release-16.0
from
planetscale:settingspool-fix
May 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot present when there is an error Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
harshit-gangal
requested review from
ajm188,
rohit-nayak-ps,
rsajwani,
shlomi-noach,
systay and
frouioui
as code owners
May 29, 2023 19:21
vitess-bot
bot
added
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
May 29, 2023
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
If a new flag is being introduced:
If a workflow is added or modified:
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
harshit-gangal
removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
labels
May 29, 2023
harshit-gangal
changed the title
Fix: TabletServer ReserveBeginExecute to return transaction ID on error
[16.0] Fix: TabletServer ReserveBeginExecute to return transaction ID on error
May 30, 2023
GuptaManan100
approved these changes
May 30, 2023
frouioui
approved these changes
May 30, 2023
harshit-gangal
added a commit
that referenced
this pull request
May 31, 2023
…ction ID on error (#13193) (#13196) * ReserveBeginExecute to return transaction id even if reserver id is not present when there is an error Signed-off-by: Harshit Gangal <[email protected]> * enabled settings pool for e2e test Signed-off-by: Harshit Gangal <[email protected]> --------- Signed-off-by: Harshit Gangal <[email protected]> Co-authored-by: Harshit Gangal <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the issue with
ReserveBeginExecute
to return transaction ID on error.Without this fix, the transaction was lost and was only cleared by the transaction killer.
There is a separate PR for main: #13127
Related Issue(s)
Checklist
Deployment Notes