[planner bugfix] add expressions to HAVING #12668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a predicate contains aggregation, it should not be added to the WHERE clause. It should go to the Signed-off-by: Andres Taylor <[email protected]>
systay
requested review from
harshit-gangal,
frouioui,
GuptaManan100 and
arthurschreiber
as code owners
frouioui
approved these changes
Mar 21, 2023
Signed-off-by: Andres Taylor <[email protected]>
…te-pushing Signed-off-by: Andres Taylor <[email protected]>
GuptaManan100
approved these changes
Mar 22, 2023
frouioui
pushed a commit
to planetscale/vitess
that referenced
this pull request
Mar 22, 2023
* [planner bugfix] add expressions to HAVING When a predicate contains aggregation, it should not be added to the WHERE clause. It should go to the Signed-off-by: Andres Taylor <[email protected]> * update test expecteations Signed-off-by: Andres Taylor <[email protected]> --------- Signed-off-by: Andres Taylor <[email protected]>
frouioui
pushed a commit
to planetscale/vitess
that referenced
this pull request
Mar 22, 2023
* [planner bugfix] add expressions to HAVING When a predicate contains aggregation, it should not be added to the WHERE clause. It should go to the Signed-off-by: Andres Taylor <[email protected]> * update test expecteations Signed-off-by: Andres Taylor <[email protected]> --------- Signed-off-by: Andres Taylor <[email protected]> Signed-off-by: Florent Poinsard <[email protected]>
frouioui
pushed a commit
to planetscale/vitess
that referenced
this pull request
Mar 22, 2023
* [planner bugfix] add expressions to HAVING When a predicate contains aggregation, it should not be added to the WHERE clause. It should go to the Signed-off-by: Andres Taylor <[email protected]> * update test expecteations Signed-off-by: Andres Taylor <[email protected]> --------- Signed-off-by: Andres Taylor <[email protected]> Signed-off-by: Florent Poinsard <[email protected]>
This was referenced Mar 22, 2023
frouioui
added a commit
that referenced
this pull request
Mar 23, 2023
* [planner bugfix] add expressions to HAVING When a predicate contains aggregation, it should not be added to the WHERE clause. It should go to the * update test expecteations --------- Signed-off-by: Andres Taylor <[email protected]> Signed-off-by: Florent Poinsard <[email protected]> Co-authored-by: Andres Taylor <[email protected]>
frouioui
added a commit
that referenced
this pull request
Mar 23, 2023
* [planner bugfix] add expressions to HAVING (#12668) * [planner bugfix] add expressions to HAVING When a predicate contains aggregation, it should not be added to the WHERE clause. It should go to the Signed-off-by: Andres Taylor <[email protected]> * update test expecteations Signed-off-by: Andres Taylor <[email protected]> --------- Signed-off-by: Andres Taylor <[email protected]> Signed-off-by: Florent Poinsard <[email protected]> * Fix plan tests Signed-off-by: Florent Poinsard <[email protected]> --------- Signed-off-by: Andres Taylor <[email protected]> Signed-off-by: Florent Poinsard <[email protected]> Co-authored-by: Andres Taylor <[email protected]>
frouioui
added a commit
that referenced
this pull request
Mar 23, 2023
* [planner bugfix] add expressions to HAVING When a predicate contains aggregation, it should not be added to the WHERE clause. It should go to the * update test expecteations --------- Signed-off-by: Andres Taylor <[email protected]> Co-authored-by: Andres Taylor <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When planning derived tables, we were pushing down predicates into the WHERE clause instead of the HAVING clause, even when the predicate contains aggregation.
Related Issue(s)
Fixes #12550
Checklist