Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always add columns in the Derived operator #12634

Merged
merged 3 commits into from
Mar 20, 2023
Merged

Always add columns in the Derived operator #12634

merged 3 commits into from
Mar 20, 2023

Conversation

frouioui
Copy link
Member

@frouioui frouioui commented Mar 15, 2023 •
edited
Loading

Description

This Pull Request fix an important bug around the derived table operator. We were not adding the columns always.

FIxes #12649

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

@vitess-bot
Copy link
Contributor

vitess-bot bot commented Mar 15, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Mar 15, 2023
@frouioui frouioui removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Mar 15, 2023
arthurschreiber
arthurschreiber approved these changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@arthurschreiber arthurschreiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@frouioui
Fix plan tests expectations
fbb1ee4 
Signed-off-by: Florent Poinsard <[email protected]>
harshit-gangal
harshit-gangal reviewed Mar 16, 2023
View reviewed changes
go/vt/vtgate/planbuilder/operators/derived.go
@@ -145,9 +145,9 @@ func (d *Derived) AddColumn(ctx *plancontext.PlanningContext, expr sqlparser.Exp
var pos int
d.ColumnsOffset, pos = addToIntSlice(d.ColumnsOffset, i)

d.Columns = append(d.Columns, col)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a comment here will be helpful.

GuptaManan100
GuptaManan100 approved these changes Mar 17, 2023
View reviewed changes
Copy link
Member

@GuptaManan100 GuptaManan100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a linked bug, but otherwise LGTM

@frouioui frouioui merged commit 6f8340b into vitessio:main Mar 20, 2023
@frouioui frouioui deleted the fix-missing-column-in-derived-operator branch March 20, 2023 16:45
frouioui added a commit to planetscale/vitess that referenced this pull request Mar 20, 2023
@frouioui @systay
Always add columns in the Derived operator (vitessio#12634)
371f9df 
* Always add column in the derived operator

Signed-off-by: Florent Poinsard <[email protected]>

* Fix plan tests expectations

Signed-off-by: Florent Poinsard <[email protected]>

---------

Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Co-authored-by: Andres Taylor <[email protected]>
@frouioui frouioui mentioned this pull request Mar 20, 2023
Merged
@frouioui frouioui mentioned this pull request Mar 21, 2023
Merged
@frouioui frouioui mentioned this pull request Mar 21, 2023
Merged
frouioui added a commit that referenced this pull request Mar 22, 2023
@frouioui @systay
Always add columns in the Derived operator (#12634) (#12670)
dc0bd69 
* Always add column in the derived operator



* Fix plan tests expectations



---------

Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Co-authored-by: Andres Taylor <[email protected]>
@hmaurer hmaurer mentioned this pull request Mar 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuptaManan100 GuptaManan100 GuptaManan100 approved these changes

@harshit-gangal harshit-gangal harshit-gangal approved these changes

@systay systay systay approved these changes

@arthurschreiber arthurschreiber arthurschreiber approved these changes

Assignees
No one assigned
Labels
Component: Query Serving Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gen4 planner does not always add the JoinVars columns to the LHS of a Join
5 participants
@frouioui @arthurschreiber @systay @harshit-gangal @GuptaManan100