Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip recalculating the rate in MaxReplicationLagModule when it can't be done #12620

Merged
merged 4 commits into from
Apr 14, 2023
Merged

Skip recalculating the rate in MaxReplicationLagModule when it can't be done #12620

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
94ba253
Skip recalculating the rate in MaxReplicationLagModule when it can't …
ejortegau Mar 13, 2023
23fdd00
Address PR comments.
ejortegau Mar 31, 2023
8b3f654
Make linter happy
ejortegau Mar 31, 2023
8c06d54
Merge branch 'vitessio:main' into ejortegau/fix_tx_throttler_segfault
ejortegau Apr 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions go/vt/throttler/max_replication_lag_module.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,6 +302,12 @@ func (m *MaxReplicationLagModule) recalculateRate(lagRecordNow replicationLagRec
if lagRecordNow.isZero() {
panic("rate recalculation was triggered with a zero replication lag record")
}

// Protect against nil stats - see https://github.com/vitessio/vitess/issues/12619
ejortegau marked this conversation as resolved.
Show resolved Hide resolved
if lagRecordNow.Stats == nil {
return
}

now := lagRecordNow.time
lagNow := lagRecordNow.lag()

Expand Down