Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Download mariadb from vitess-resources #12271

Merged
merged 3 commits into from
Feb 8, 2023
Merged

Download mariadb from vitess-resources #12271

merged 3 commits into from
Feb 8, 2023

Conversation

frouioui
Copy link
Member

@frouioui frouioui commented Feb 8, 2023

Description

We are now downloading MariaDB from vitess-resources v4.

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Documentation was added or is not required

@frouioui frouioui requested a review from deepthi as a code owner February 8, 2023 11:18
@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Feb 8, 2023
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Feb 8, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@frouioui frouioui added Backport to: release-15.0 Component: Build/CI Type: CI/Build and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Feb 8, 2023
@frouioui
Use 10.10.3 instead of LTS
ac21bf1 
Signed-off-by: Florent Poinsard <[email protected]>
@frouioui
Copy link
Member Author

frouioui commented Feb 8, 2023

Reading through @mattlord comment #12036 (comment), I have reverted the change to use 10.10.3 instead of 10.6.12.

mattlord
mattlord approved these changes Feb 8, 2023
View reviewed changes
Copy link
Contributor

@mattlord mattlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @frouioui! I was going to bring this issue up today and come to some resolution so you saved me a bunch of time.❤️

@frouioui frouioui merged commit da69672 into vitessio:main Feb 8, 2023
@frouioui frouioui deleted the fix-mariadb-install branch February 8, 2023 15:04
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Feb 8, 2023

I was unable to backport this Pull Request to the following branches: release-16.0.

@frouioui frouioui mentioned this pull request Feb 8, 2023
Closed
frouioui added a commit to planetscale/vitess that referenced this pull request Feb 8, 2023
@frouioui
Download mariadb from vitess-resources (vitessio#12271)
331acc8 
* Download mariadb from vitess-resources

Signed-off-by: Florent Poinsard <[email protected]>

* Use proper mariadb version increment in tests

Signed-off-by: Florent Poinsard <[email protected]>

* Use 10.10.3 instead of LTS

Signed-off-by: Florent Poinsard <[email protected]>

---------

Signed-off-by: Florent Poinsard <[email protected]>
@frouioui frouioui mentioned this pull request Feb 8, 2023
Merged
3 tasks
frouioui added a commit that referenced this pull request Feb 9, 2023
@frouioui
Download mariadb from vitess-resources (#12271) (#12279)
8c57874 
* Download mariadb from vitess-resources



* Use proper mariadb version increment in tests



* Use 10.10.3 instead of LTS



---------

Signed-off-by: Florent Poinsard <[email protected]>
@hmaurer hmaurer mentioned this pull request Mar 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbussink dbussink dbussink approved these changes

@arthurschreiber arthurschreiber arthurschreiber approved these changes

@systay systay systay approved these changes

@mattlord mattlord mattlord approved these changes

@GuptaManan100 GuptaManan100 GuptaManan100 approved these changes

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

Assignees
No one assigned
Labels
Component: Build/CI Type: CI/Build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@frouioui @arthurschreiber @dbussink @systay @mattlord @GuptaManan100