-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vtctldserver] Remove parallelization from tests that mutate shared state #12257
[vtctldserver] Remove parallelization from tests that mutate shared state #12257
Conversation
Signed-off-by: Andrew Mason <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
If a new flag is being introduced:
If a workflow is added or modified:
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
Signed-off-by: Florent Poinsard <[email protected]>
Merged |
I was unable to backport this Pull Request to the following branches: |
This test failed on #13290 (release-16.0), so I'm applying this fix manually into that PR. There is no longer a need to do a separate manual backport. |
Description
This removes
t.Parallel
from the test cases that mutate the stubbed out "get version" function, which trips the race detector.VTAdmin integration tests also indirectly hit this, because
testutil.BuildIntegrationTestCluster
instantiates agrpcvtctldserver.Server
, which can race. This is why I believe we've been seeing vtadmin tests showing up as flaky in launchable.Related Issue(s)
N/A
Checklist
Deployment Notes