Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vtctldserver] Remove parallelization from tests that mutate shared state #12257

Merged
merged 2 commits into from
Feb 9, 2023

Conversation

ajm188
Copy link
Contributor

@ajm188 ajm188 commented Feb 6, 2023

Description

This removes t.Parallel from the test cases that mutate the stubbed out "get version" function, which trips the race detector.

VTAdmin integration tests also indirectly hit this, because testutil.BuildIntegrationTestCluster instantiates a grpcvtctldserver.Server, which can race. This is why I believe we've been seeing vtadmin tests showing up as flaky in launchable.

Related Issue(s)

N/A

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

@ajm188 ajm188 requested a review from GuptaManan100 February 6, 2023 21:56
@ajm188 ajm188 requested a review from notfelineit as a code owner February 6, 2023 21:56
@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Feb 6, 2023
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Feb 6, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@GuptaManan100 GuptaManan100 removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Feb 9, 2023
@frouioui
Copy link
Member

frouioui commented Feb 9, 2023

Merged main to make vreplication_across_db_versions go green :)

@GuptaManan100 GuptaManan100 merged commit 2da58c0 into vitessio:main Feb 9, 2023
@GuptaManan100 GuptaManan100 deleted the andrew/deflake-vtadmin branch February 9, 2023 12:12
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Feb 9, 2023

I was unable to backport this Pull Request to the following branches: release-16.0.

@deepthi
Copy link
Member

deepthi commented Jun 14, 2023

I was unable to backport this Pull Request to the following branches: release-16.0.

This test failed on #13290 (release-16.0), so I'm applying this fix manually into that PR. There is no longer a need to do a separate manual backport.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants