-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Ubuntu 20.04 for Release Builds #12202
Conversation
Signed-off-by: Matt Lord <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
If a new flag is being introduced:
If a workflow is added or modified:
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank-you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
I was unable to backport this Pull Request to the following branches: |
Signed-off-by: Matt Lord <[email protected]>
The underlying issue has now been addressed in: vitessio#12214 This reverts commit 4b3b37d. Signed-off-by: Matt Lord <[email protected]>
The underlying issue has now been addressed in: #12214 This reverts commit 4b3b37d. Signed-off-by: Matt Lord <[email protected]>
Description
This moves the release package build CI workflow to Ubuntu 20.04, which is the oldest supported Linux distro available on GitHub hosted runners today.
This will get us back to what we were using with v14 and the
vtorc
binary — which links in the nativesqlite
C
library viacgo
— will be usable on a larger set of Linux distros. For additional details see: #12185We may want to investigate additional options at some point, even going so far as attempting to statically link
glibc
insqlite
and using that resulting archive rather than shared object, but this PR gets us back to where we were and improves the situation significantly.Related Issue(s)
Checklist