Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Ubuntu 20.04 for Release Builds #12202

Merged
merged 1 commit into from
Feb 1, 2023

Conversation

mattlord
Copy link
Contributor

@mattlord mattlord commented Feb 1, 2023

Description

This moves the release package build CI workflow to Ubuntu 20.04, which is the oldest supported Linux distro available on GitHub hosted runners today.

This will get us back to what we were using with v14 and the vtorc binary — which links in the native sqlite C library via cgo — will be usable on a larger set of Linux distros. For additional details see: #12185

We may want to investigate additional options at some point, even going so far as attempting to statically link glibc in sqlite and using that resulting archive rather than shared object, but this PR gets us back to where we were and improves the situation significantly.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests are not required
  • Documentation is not required

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Feb 1, 2023
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Feb 1, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@mattlord mattlord added Component: Build/CI and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Feb 1, 2023
@mattlord mattlord marked this pull request as ready for review February 1, 2023 16:03
Copy link
Member

@GuptaManan100 GuptaManan100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank-you!

Copy link
Contributor

@rohit-nayak-ps rohit-nayak-ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattlord mattlord merged commit 4b3b37d into vitessio:main Feb 1, 2023
@mattlord mattlord deleted the releases_20.04 branch February 1, 2023 17:12
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Feb 1, 2023

I was unable to backport this Pull Request to the following branches: release-15.0.

mattlord added a commit to planetscale/vitess that referenced this pull request Feb 1, 2023
@GuptaManan100 GuptaManan100 mentioned this pull request Feb 1, 2023
35 tasks
mattlord added a commit to planetscale/vitess that referenced this pull request Feb 2, 2023
The underlying issue has now been addressed in:
  vitessio#12214

This reverts commit 4b3b37d.

Signed-off-by: Matt Lord <[email protected]>
mattlord added a commit that referenced this pull request Feb 2, 2023
The underlying issue has now been addressed in:
  #12214

This reverts commit 4b3b37d.

Signed-off-by: Matt Lord <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants