Move horizon planning to operators #11622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
… operators Signed-off-by: Andres Taylor <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
If a new flag is being introduced:
If a workflow is added or modified:
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
frouioui
added
Type: Enhancement
frouioui
commented
Nov 2, 2022
Comment on lines
70
to
+71
| // Clone implements the Operator interface | ||
| func (a *ApplyJoin) Clone(inputs []Operator) Operator { | ||
| func (a *ApplyJoin) clone(inputs []Operator) Operator { |
There was a problem hiding this comment.
nit: we can also change the comment Clone -> clone
Signed-off-by: Andres Taylor <[email protected]>
systay
force-pushed
the
operator-horizon
branch
from
c74cf88 to
079bc33
Compare
frouioui
commented
Nov 3, 2022
Comment on lines
+52
to
+53
| } | ||
| func planSingleShardRoute(statement sqlparser.SelectStatement, rb *Route, horizon *Horizon) (Operator, error) { |
frouioui
commented
Nov 3, 2022
| "vitess.io/vitess/go/vt/vtgate/planbuilder/plancontext" | ||
| ) | ||
|
|
||
| // Horizon is an operator we use until we decide how to handle the source to the horizon. |
There was a problem hiding this comment.
I am not sure I fully understand this. We add the Horizon operator into the tree until we have decided how the rest of the tree will do horizon planning?
There was a problem hiding this comment.
Looking at the operator test data, it feels like it encapsulates each node in the tree.
There was a problem hiding this comment.
Yes. We need to do the physical route planning before we do the horizon planning
frouioui
commented
Nov 3, 2022
Comment on lines
+17
to
+20
| // Package operators contains the operators used to plan queries. | ||
| /* | ||
| The operators go through a few phases while planning: | ||
| 1. Logical |
There was a problem hiding this comment.
I'll add info about horizons in the op tree as well
frouioui
commented
Nov 3, 2022
|
We should update the Pull Request description. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A refactoring that introduces a Horizon as a logical operator.
During query planning, we start by figuring out where we are going to send the queries. This is done by inspecting the
FROM&WHEREclauses.A horizon is what we call in the planner the stuff that is outside the
FROM ... WHEREclause. If we are able to send the whole query to a single shard, we don't do much more planning - we simply add the rest of the clauses (projections, ordering, limit, aggregation and more) to the query and we are done.If we can't delegate everything to MySQL, we do more planning, and this is what we call horizon planning.
This change moves the horizon into the operator tree, instead of having special handling of derived tables, unions and subqueries.
Related Issue(s)
#11626
Checklist
Deployment Notes