-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VTAdmin] RebuildKeyspaceGraph, RemoveKeyspaceCell, NewShard #11249
Conversation
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't review this at a code level, but looks good from UI perspective.
@notfelineit I just noticed that DCO check is failing. You will need to squash all the commits and add a sign-off.
|
6dfc576
to
d593ebe
Compare
@deepthi I followed the instructions here: https://github.com/vitessio/vitess/pull/11249/checks?check_run_id=8457122971 and a bunch of other commits were pulled in 😭 EDIT: I rebased off upstream again to fix the history! |
Signed-off-by: notfelineit <[email protected]>
Signed-off-by: notfelineit <[email protected]>
Signed-off-by: notfelineit <[email protected]>
Signed-off-by: notfelineit <[email protected]>
Signed-off-by: notfelineit <[email protected]>
Signed-off-by: notfelineit <[email protected]>
Signed-off-by: notfelineit <[email protected]>
Signed-off-by: notfelineit <[email protected]>
Signed-off-by: notfelineit <[email protected]>
Signed-off-by: notfelineit <[email protected]>
Signed-off-by: notfelineit <[email protected]>
Signed-off-by: notfelineit <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]> Signed-off-by: notfelineit <[email protected]>
Signed-off-by: notfelineit <[email protected]>
d593ebe
to
98248b9
Compare
Signed-off-by: notfelineit [email protected]
Description
This PR implements the following "keyspace" actions:
It implements the portion from UI to VTAdmin API, calling the already implemented vtctldclient method.
Rebuild/Remove
Change
Related Issue(s)
Checklist
Deployment Notes