Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VTAdmin] RebuildKeyspaceGraph, RemoveKeyspaceCell, NewShard #11249

Merged
merged 14 commits into from
Sep 23, 2022

Conversation

notfelineit
Copy link
Contributor

@notfelineit notfelineit commented Sep 16, 2022

Signed-off-by: notfelineit [email protected]

Description

This PR implements the following "keyspace" actions:

  • RebuildKeyspaceGraph
  • CreateShard
  • RemoveKeyspaceShard

It implements the portion from UI to VTAdmin API, calling the already implemented vtctldclient method.

Rebuild/Remove
Screen Shot 2022-09-20 at 10 13 48 AM

Change
Screen Shot 2022-09-20 at 10 13 57 AM

Related Issue(s)

Checklist

  • "Backport me!" label has been added if this change should be backported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

@vitess-bot
Copy link
Contributor

vitess-bot bot commented Sep 16, 2022

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a new flag is being introduced, review whether it is really needed. The flag names should be clear and intuitive (as far as possible), and the flag's help should be descriptive. Additionally, flag names should use dashes (-) as word separators rather than underscores (_).
  • If a workflow is added or modified, each items in Jobs should be named in order to mark it as required. If the workflow should be required, the GitHub Admin should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should either include a link to an issue that describes the bug OR an actual description of the bug and how to reproduce, along with a description of the fix.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.

Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't review this at a code level, but looks good from UI perspective.

@deepthi
Copy link
Member

deepthi commented Sep 20, 2022

@notfelineit I just noticed that DCO check is failing. You will need to squash all the commits and add a sign-off.

git commit -a -s

@notfelineit
Copy link
Contributor Author

notfelineit commented Sep 20, 2022

@deepthi I followed the instructions here: https://github.com/vitessio/vitess/pull/11249/checks?check_run_id=8457122971 and a bunch of other commits were pulled in 😭

EDIT: I rebased off upstream again to fix the history!

notfelineit and others added 6 commits September 20, 2022 13:59
Signed-off-by: notfelineit <[email protected]>
Signed-off-by: notfelineit <[email protected]>
Signed-off-by: notfelineit <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: notfelineit <[email protected]>
@notfelineit notfelineit force-pushed the frances/keyspace-actions branch from d593ebe to 98248b9 Compare September 20, 2022 20:59
@deepthi deepthi merged commit ce558fc into vitessio:main Sep 23, 2022
@deepthi deepthi deleted the frances/keyspace-actions branch September 23, 2022 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants