-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor vtorc tests to run as a single test with sub-tests #11108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manan Gupta <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
LGTM |
rsajwani
approved these changes
Aug 30, 2022
timvaillancourt
pushed a commit
to slackhq/vitess
that referenced
this pull request
Oct 11, 2023
…vitessio#11108) Signed-off-by: Manan Gupta <[email protected]> Signed-off-by: Manan Gupta <[email protected]>
timvaillancourt
added a commit
to slackhq/vitess
that referenced
this pull request
Oct 13, 2023
* refactor: refactor vtorc tests to run as a single test with sub-tests (vitessio#11108) Signed-off-by: Manan Gupta <[email protected]> Signed-off-by: Manan Gupta <[email protected]> * `vtctld`/`vtorc`: improve reparenting stats (vitessio#13723) Signed-off-by: Tim Vaillancourt <[email protected]> Signed-off-by: Manan Gupta <[email protected]> Co-authored-by: Manan Gupta <[email protected]> * revert changes to go/test/endtoend Signed-off-by: Tim Vaillancourt <[email protected]> * remove unrelated+incompatible test Signed-off-by: Tim Vaillancourt <[email protected]> * Fix memorytopo.NewServer(...) for v14 Signed-off-by: Tim Vaillancourt <[email protected]> * remove non-existant "PrimaryStatusResults" field Signed-off-by: Tim Vaillancourt <[email protected]> * Remove FOSSA Test from CI until we can do it in a secure way (vitessio#14119) Signed-off-by: Rohit Nayak <[email protected]> --------- Signed-off-by: Manan Gupta <[email protected]> Signed-off-by: Tim Vaillancourt <[email protected]> Signed-off-by: Rohit Nayak <[email protected]> Co-authored-by: Manan Gupta <[email protected]> Co-authored-by: Manan Gupta <[email protected]> Co-authored-by: Rohit Nayak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors some VTOrc tests to run as a single test with sub-tests. The time of execution is brought down from 6 minutes 34 seconds to 5 minutes 5 seconds.
Related Issue(s)
Checklist
Deployment Notes