Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schemadiff: FullTextKeyStrategy, handling multiple 'ADD FULLTEXT key' alter options #11012

Merged
merged 2 commits into from
Aug 15, 2022

Conversation

shlomi-noach
Copy link
Contributor

Description

MySQL does not support multiple ADD FULLTEXT KEY clauses in the same ALTER TABLE statement.

schemadiff now supports a FullTextKeyStrategy with the following options:

  • FullTextKeyDistinctStatements (default): generate distinct ALTER statements when there's more than one ADD FULLTEXT clause; these statements will be valid to run on MySQL
  • FullTextKeyUnifyStatements, generate a single ALTER statement with multiple ADD FULLTEXT clauses. Reasons to use this strategy:
    • We will make this statement valid for Vitess's Online DDL
    • MySQL may remove this limitation in the future.

Tests added.

Related Issue(s)

Checklist

  • "Backport me!" label has been added if this change should be backported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

@shlomi-noach shlomi-noach added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Query Serving labels Aug 15, 2022
@shlomi-noach shlomi-noach requested a review from dbussink August 15, 2022 11:07
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Aug 15, 2022

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a new flag is being introduced, review whether it is really needed. The flag names should be clear and intuitive (as far as possible), and the flag's help should be descriptive.
  • If a workflow is added or modified, each items in Jobs should be named in order to mark it as required. If the workflow should be required, the GitHub Admin should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should either include a link to an issue that describes the bug OR an actual description of the bug and how to reproduce, along with a description of the fix.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.

Signed-off-by: Shlomi Noach <[email protected]>
@deepthi deepthi merged commit 3999a0f into vitessio:main Aug 15, 2022
@deepthi deepthi deleted the schemadiff-innodb-fulltext branch August 15, 2022 19:06
systay pushed a commit to planetscale/vitess that referenced this pull request Aug 19, 2022
… alter options (vitessio#11012) (vitessio#961)

* schemadiff: FullTextKeyStrategy, handling multiple 'ADD FULLTEXT key' options

Signed-off-by: Shlomi Noach <[email protected]>

* removed debug info

Signed-off-by: Shlomi Noach <[email protected]>

Signed-off-by: Shlomi Noach <[email protected]>

Signed-off-by: Shlomi Noach <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants