Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate enable-semi-sync in favour of RPC parameter #10695

Merged
merged 12 commits into from
Jul 22, 2022
Merged

Deprecate enable-semi-sync in favour of RPC parameter #10695

merged 12 commits into from
Jul 22, 2022

Conversation

GuptaManan100
Copy link
Member

@GuptaManan100 GuptaManan100 commented Jul 14, 2022 •
edited
Loading

Description

This PR deprecates the enable_semi_sync flag. Instead, the semi-sync is set using the parameter passed down in the RPC as added in #9533.

This also enables us to use the durability policy cross_cell since VTOrc and vtctld take over the responsibility of setting the correct semi-sync value instead of a static flag. An end to end test for this durability policy has also been added in this PR.

Related Issue(s)

Checklist

Deployment Notes

@GuptaManan100 GuptaManan100 added Type: Internal Cleanup Component: Cluster management release notes (needs details) This PR needs to be listed in the release notes in a dedicated section (deprecation notice, etc...) labels Jul 14, 2022
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Jul 14, 2022 •
edited by deepthi
Loading

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a new flag is being introduced, review whether it is really needed. The flag names should be clear and intuitive (as far as possible), and the flag's help should be descriptive. Additionally, flag names should use dashes (-) as word separators rather than underscores (_).
  • If a workflow is added or modified, each items in Jobs should be named in order to mark it as required. If the workflow should be required, the GitHub Admin should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should either include a link to an issue that describes the bug OR an actual description of the bug and how to reproduce, along with a description of the fix.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.

@GuptaManan100 GuptaManan100 added Type: Enhancement Logical improvement (somewhere between a bug and feature) and removed Type: Internal Cleanup labels Jul 18, 2022
@GuptaManan100 GuptaManan100 marked this pull request as ready for review July 19, 2022 14:28
@GuptaManan100 GuptaManan100 mentioned this pull request Jul 19, 2022
Merged
@GuptaManan100 GuptaManan100 added release notes (needs details) This PR needs to be listed in the release notes in a dedicated section (deprecation notice, etc...) and removed release notes (needs details) This PR needs to be listed in the release notes in a dedicated section (deprecation notice, etc...) labels Jul 19, 2022
@GuptaManan100 GuptaManan100 removed the release notes (needs details) This PR needs to be listed in the release notes in a dedicated section (deprecation notice, etc...) label Jul 19, 2022
deepthi
deepthi reviewed Jul 19, 2022
View reviewed changes
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM. I can re-review once the comments are addressed.
Since we have dropped support for MariaDB 10.2, we can actually go ahead and delete mariadb100.cnf, mariadb101.cnf and mariadb102.cnf.

go/flags/endtoend/vttablet.txt Outdated Show resolved Hide resolved
go/test/endtoend/reparent/utils/utils.go Show resolved Hide resolved
go/vt/vttablet/tabletmanager/rpc_replication.go Outdated Show resolved Hide resolved
go/vt/vttablet/tabletmanager/rpc_replication_test.go Show resolved Hide resolved
@GuptaManan100
feat: fix flag help output
2871455 
Signed-off-by: Manan Gupta <[email protected]>
@GuptaManan100
Copy link
Member Author

GuptaManan100 commented Jul 21, 2022 •
edited
Loading

@deepthi History has taught me not to merge enable_semi_sync changes with any other change 🤣 . I'll remove the mariadb.cnf files in a separate PR following this one.

@GuptaManan100 GuptaManan100 requested a review from deepthi July 21, 2022 12:26
@GuptaManan100
Copy link
Member Author

There is a failing upgrade-downgrade test. Investigating...

@GuptaManan100
Copy link
Member Author

GuptaManan100 commented Jul 21, 2022 •
edited
Loading

Turned out to be a real easy fix. I had removed enable_semi_sync from a test that was testing upgrades.

@GuptaManan100 GuptaManan100 merged commit ed9e6e3 into vitessio:main Jul 22, 2022
@GuptaManan100 GuptaManan100 deleted the semi-sync-cutover-15 branch July 22, 2022 16:05
rsajwani pushed a commit to planetscale/vitess that referenced this pull request Aug 1, 2022
@GuptaManan100
Deprecate enable-semi-sync in favour of RPC parameter (vitessio#10695) (
18d48fb 
vitessio#858)

* feat: deprecate enable_semi_sync flag

Signed-off-by: Manan Gupta <[email protected]>

* docs: add the deprecation change to the summary

Signed-off-by: Manan Gupta <[email protected]>

* test: fix test expectation for vttablet flags

Signed-off-by: Manan Gupta <[email protected]>

* feat: fix cnf files to not mention the deprecated flag

Signed-off-by: Manan Gupta <[email protected]>

* feat: remove enable_semi_sync from scripts of examples

Signed-off-by: Manan Gupta <[email protected]>

* test: remove setting enable_semi_sync flag in testlib tests

Signed-off-by: Manan Gupta <[email protected]>

* feat: remove enable_semi_sync from a bunch of tests

Signed-off-by: Manan Gupta <[email protected]>

* test: refactor setup to take in durability policy instead of a boolean and add a test for cross cell durability policy

Signed-off-by: Manan Gupta <[email protected]>

* feat: add cross cell durability policy to the docs

Signed-off-by: Manan Gupta <[email protected]>

* feat: fix flag help output

Signed-off-by: Manan Gupta <[email protected]>

* test: we shouldn't remove enable_semi_sync from tests which are testing upgrades

Signed-off-by: Manan Gupta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthi deepthi deepthi approved these changes

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

@shlomi-noach shlomi-noach Awaiting requested review from shlomi-noach shlomi-noach is a code owner

@frouioui frouioui Awaiting requested review from frouioui frouioui is a code owner

Assignees
No one assigned
Labels
Component: Cluster management Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuptaManan100 @deepthi