[13.0] Backport Add support for non aggregated columns in OrderedAggregate
#10324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ull_group_by issue Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
* Do not send field query when using reserved connection Signed-off-by: Florent Poinsard <[email protected]> * Fixed the expected output of tabletserver unit tests Signed-off-by: Florent Poinsard <[email protected]> * Addition of an end-to-end benchmark for a select in a reserved connectio Signed-off-by: Florent Poinsard <[email protected]> * Reuse reserved connection hen sending field query Signed-off-by: Florent Poinsard <[email protected]> * Fail queries when setting unsupported sql_mode Signed-off-by: Florent Poinsard <[email protected]> * error out for unsupported sql mode only when the mode is changed Signed-off-by: Florent Poinsard <[email protected]>
frouioui
added
Type: Enhancement
frouioui
requested review from
harshit-gangal,
systay and
shlomi-noach
as code owners
|
@rohit-nayak-ps, I will investigate why |
Signed-off-by: Florent Poinsard <[email protected]>
|
d038c39 fixes the flakiness observed in |
systay
approved these changes
May 19, 2022
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
…eturns an error Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
…essio#10153) Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
|
@frouioui It has been a month since this PR was created. Do we want to merge it or close it? |
|
@GuptaManan100, we are still looking at it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request is a backport of #10139. Among the changes backported from #10139, the changes done in #10163 are also backported (2682ecb), they were required to successfully implement #10139.
Related Issue(s)
Checklist