Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for empty results when no shards can be found to route to [v3] #10204

Closed
wants to merge 1 commit into from

Conversation

systay
Copy link
Collaborator

@systay systay commented May 3, 2022

Description

Queries that follow the following pattern -

select exists(select * from foo where some_field=some_value)

The table foo would has a lookup vindex on some_field and there are no matching rows for some_value. What Vitess would do when no shards could be found to route to is to return an empty result. This is correct for most cases, but not always. The query above would return an empty result instead of a 0.

This fix is for the V3 planner.

Related Issue(s)

Fixes #10144
Forward port of #10202

Checklist

  • "Backport me!" label has been added if this change should be backported
  • Tests were added or are not required
  • Documentation was added or is not required

@systay systay added Type: Bug Component: Java Pull requests that update Java code release notes labels May 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2022

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has the correct release notes label. release notes none should only be used for PRs that are so trivial that they need not be included.
  • If a new flag is being introduced, review whether it is really needed. The flag names should be clear and intuitive (as far as possible), and the flag's help should be descriptive.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should either include a link to an issue that describes the bug OR an actual description of the bug and how to reproduce, along with a description of the fix.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.

@frouioui frouioui added Backport me! Component: Query Serving and removed Component: Java Pull requests that update Java code labels May 3, 2022
@systay
Copy link
Collaborator Author

systay commented May 24, 2022

will re-open once #10202 is done

@systay systay closed this May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug Report: exists may returns random result on a sharded table
2 participants