Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename master_alias to primary_alias in reparent_journal table #10098

Merged
merged 1 commit into from
Apr 15, 2022

Conversation

deepthi
Copy link
Member

@deepthi deepthi commented Apr 14, 2022

Description

Rename the column for new installs where table will get created
Add an alter statement for upgrades
Change all places where we access the column to use the new name

Related Issue(s)

Fixes #8619
Related #9439

Checklist

  • "Backport me!" label has been added if this change should be backported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

Copy link
Contributor

@mattlord mattlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@rohit-nayak-ps rohit-nayak-ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rohit-nayak-ps rohit-nayak-ps merged commit 265e058 into vitessio:main Apr 15, 2022
@rohit-nayak-ps rohit-nayak-ps deleted the ds-primary-alias branch April 15, 2022 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task: rename column master_alias in table _vt.reparent_journal
3 participants