Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Gen4 only_full_group_by regression #10069

Merged
merged 2 commits into from
Apr 12, 2022
Merged

Fix Gen4 only_full_group_by regression #10069

merged 2 commits into from
Apr 12, 2022

Conversation

frouioui
Copy link
Member

@frouioui frouioui commented Apr 11, 2022 •
edited
Loading

Description

This PR fixes #9889.

Checklist

  • Should this PR be backported?
  • Tests were added or are not required
  • Documentation was added or is not required

@frouioui
fix: remove unrequired plan tests
42e5a61 
Signed-off-by: Florent Poinsard <[email protected]>
@frouioui frouioui marked this pull request as ready for review April 12, 2022 09:05
@frouioui frouioui mentioned this pull request Apr 12, 2022
Merged
3 tasks
@frouioui frouioui merged commit ac21027 into vitessio:main Apr 12, 2022
@frouioui frouioui deleted the fix-group-by-regression branch April 12, 2022 15:03
This was referenced Apr 12, 2022
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@systay systay systay approved these changes

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

Assignees
No one assigned
Labels
Component: Query Serving Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug Report: false negative sql_mode=only_full_group_by error message from vtgate
2 participants
@frouioui @systay