Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in vttablet pool config field maxRows #8819

Closed
aquarapid opened this issue Sep 14, 2021 · 0 comments
Closed

Typo in vttablet pool config field maxRows #8819

aquarapid opened this issue Sep 14, 2021 · 0 comments
Labels
Type: Bug

Comments

@aquarapid
Copy link
Contributor

https://github.com/vitessio/vitess/blob/main/go/vt/vttablet/tabletserver/tabletenv/config.go#L302

Should be maxRows, not maxRpws.

I think usage of config files for pool configs is low enough we can just fix this directly without doing something backwards compatible?
@systay systay closed this as completed in 65a1b7e Sep 22, 2021
systay added a commit that referenced this issue Sep 22, 2021
@systay
Merge pull request #8820 from planetscale/jg_configtypo
68fa0c8 
Fix typo in pool config syntax.  Fixes #8819
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aquarapid