Changes from self review

Signed-off-by: Matt Lord <[email protected]>

go/mysql/binlog_event_common.go

@@ -47,7 +47,7 @@ import (
 //	+----------------------------+
 //	| extra_headers    19 : x-19 |
 //	+============================+
-//	https://dev.mysql.com/doc/dev/mysql-server/8.0.40/page_protocol_replication_binlog_event.html#sect_protocol_replication_binlog_event_header
+//	https://dev.mysql.com/doc/dev/mysql-server/latest/page_protocol_replication_binlog_event.html#sect_protocol_replication_binlog_event_header
 type binlogEvent []byte
 
 const (

go/mysql/replication.go

@@ -33,8 +33,8 @@ const (
 // This file contains the methods related to replication.
 
 // WriteComBinlogDump writes a ComBinlogDump command.
-// See http://dev.mysql.com/doc/internals/en/com-binlog-dump.html for syntax.
 // Returns a SQLError.
+// See: https://dev.mysql.com/doc/dev/mysql-server/latest/page_protocol_com_binlog_dump.html
 func (c *Conn) WriteComBinlogDump(serverID uint32, binlogFilename string, binlogPos uint64, flags uint16) error {
 	// The binary log file position is a uint64, but the protocol command
 	// only uses 4 bytes for the file position.

go/mysql/replication/primary_status.go

@@ -28,8 +28,7 @@ import (
 type PrimaryStatus struct {
 	// Position represents the server's GTID based position.
 	Position Position
-	// FilePosition represents the server's file/pos based replication
-	// pseudo GTID position.
+	// FilePosition represents the server's file based position.
 	FilePosition Position
 	// ServerUUID is the UUID of the server.
 	ServerUUID string

go/vt/vtorc/inst/instance_dao.go

@@ -281,7 +281,7 @@ func ReadTopologyInstanceBufferable(tabletAlias string, latency *stopwatch.Named
 		errorChan <- err
 		instance.IsDetached, _ = instance.ExecBinlogCoordinates.ExtractDetachedCoordinates()
 
-		binlogPos, err = getBinlogCoordinatesFromPositionString(fs.ReplicationStatus.FilePosition)
+		binlogPos, err = getBinlogCoordinatesFromPositionString(fs.ReplicationStatus.RelayLogFilePosition)
 		instance.RelaylogCoordinates = binlogPos
 		instance.RelaylogCoordinates.Type = RelayLog
 		errorChan <- err