Merge pull request #9067 from planetscale/MySQL56EOLTests

Remove Percona5.6 Unit Tests for Vitess 13.0
vitessio · Oct 22, 2021 · b337828 · b337828
2 parents ff2881a + adc6e01
commit b337828
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 92 deletions.
diff --git a/.github/workflows/unit_test_percona56.yml b/.github/workflows/unit_test_percona56.yml
diff --git a/go/vt/vttablet/tabletmanager/vreplication/vplayer_flaky_test.go b/go/vt/vttablet/tabletmanager/vreplication/vplayer_flaky_test.go
@@ -2432,7 +2432,6 @@ func TestTimestamp(t *testing.T) {
 func shouldRunJSONTests(t *testing.T, name string) bool {
 	skipTest := true
 	flavors := []string{"mysql80", "mysql57"}
-	//flavors = append(flavors, "mysql56") // uncomment for local testing, in CI it fails on percona56
 	for _, flavor := range flavors {
 		if strings.EqualFold(env.Flavor, flavor) {
 			skipTest = false

diff --git a/test/README.md b/test/README.md
@@ -4,7 +4,7 @@ This document has a short outline of how tests are run in CI, how to add new tes
 
 ### Adding a new test
 
-Unit tests are run by the unit test runner, one per platform, currently percona56, mysql57, mysql80, mariadb101, mariadb102, mariadb103.
+Unit tests are run by the unit test runner, one per platform, currently mysql57, mysql80, mariadb101, mariadb102, mariadb103.
 The workflow first installs the required database server before calling `make unit_test`.
 
 To add a new end-to-end (e2e) test (also called _cluster end to end_ tests):
@@ -41,4 +41,4 @@ which Test VM should run this test. All tests which have a common Shard value ar
 
 * Each VM does not seem to be able to create a lot of vttablets. For this reason we have had to split a few VReplication 
 e2e tests across Shards. We need to identify and if possible fix this limitation so that we can reduce the number of test Shards
-
+
diff --git a/test/ci_workflow_gen.go b/test/ci_workflow_gen.go
@@ -30,7 +30,7 @@ const (
 	workflowConfigDir = "../.github/workflows"
 
 	unitTestTemplate  = "templates/unit_test.tpl"
-	unitTestDatabases = "percona56, mysql80, mariadb102"
+	unitTestDatabases = "mysql80, mariadb102"
 
 	clusterTestTemplate = "templates/cluster_endtoend_test.tpl"
 

diff --git a/test/templates/unit_test.tpl b/test/templates/unit_test.tpl
@@ -50,18 +50,6 @@ jobs:
         sudo rm -rf /var/lib/mysql
         sudo rm -rf /etc/mysql
 
-        {{if (eq .Platform "percona56")}}
-
-        # percona56
-        sudo rm -rf /var/lib/mysql
-        sudo apt install -y gnupg2
-        wget https://repo.percona.com/apt/percona-release_latest.$(lsb_release -sc)_all.deb
-        sudo dpkg -i percona-release_latest.$(lsb_release -sc)_all.deb
-        sudo apt update
-        sudo DEBIAN_FRONTEND="noninteractive" apt-get install -y percona-server-server-5.6 percona-server-client-5.6
-
-        {{end}}
-
         {{if (eq .Platform "mysql80")}}
 
         # mysql80