Skip to content

Commit

Permalink
typos fixed per review
Browse files Browse the repository at this point in the history
Signed-off-by: Shlomi Noach <[email protected]>
  • Loading branch information
shlomi-noach committed Mar 7, 2021
1 parent 8f671c7 commit 924d13b
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions go/test/endtoend/onlineddl_revert/onlineddl_revert_test.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
Copyright 2019 The Vitess Authors.
Copyright 2021 The Vitess Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -275,7 +275,7 @@ func TestSchemaChange(t *testing.T) {
testSelectTableMetrics(t)
})
t.Run("fail revert older change", func(t *testing.T) {
// We shouldn't be able to revert one-before-last succcessfulk migration.
// We shouldn't be able to revert one-before-last succcessful migration.
uuid := testRevertMigration(t, uuids[len(uuids)-2])
uuids = append(uuids, uuid)
checkRecentMigrations(t, uuid, schema.OnlineDDLStatusFailed)
Expand Down Expand Up @@ -544,7 +544,7 @@ func checkRecentMigrations(t *testing.T, uuid string, expectStatus schema.Online
fmt.Println("# 'vtctlclient OnlineDDL show recent' output (for debug purposes):")
fmt.Println(result)
assert.Equal(t, len(clusterInstance.Keyspaces[0].Shards), strings.Count(result, uuid))
// We ensure "full word" regexp becuase some column names may conflict
// We ensure "full word" regexp because some column names may conflict
expectStatusRegexp := fullWordUUIDRegexp(uuid, string(expectStatus))
m := expectStatusRegexp.FindAllString(result, -1)
assert.Equal(t, len(clusterInstance.Keyspaces[0].Shards), len(m))
Expand Down
2 changes: 1 addition & 1 deletion go/vt/schema/online_ddl.go
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ func (onlineDDL *OnlineDDL) GetActionStr() (action sqlparser.DDLAction, actionSt

// GetRevertUUID works when this migration is a revert for another migration. It returns the UUID
// fo the reverted migration.
// The functio nreturns error when this is not a revert migration.
// The function returns error when this is not a revert migration.
func (onlineDDL *OnlineDDL) GetRevertUUID() (uuid string, err error) {
if submatch := revertStatementRegexp.FindStringSubmatch(onlineDDL.SQL); len(submatch) > 0 {
return submatch[1], nil
Expand Down

0 comments on commit 924d13b

Please sign in to comment.