Merge pull request #7992 from tinyspeck/am_missing_return

Add missing return on a failed `GetShard` call in `FindAllShardsInKeyspace`
vitessio · May 4, 2021 · 8e0531f · 8e0531f
2 parents ac80186 + 641b442
commit 8e0531f
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/go/vt/topo/keyspace.go b/go/vt/topo/keyspace.go
@@ -234,7 +234,7 @@ func (ts *Server) FindAllShardsInKeyspace(ctx context.Context, keyspace string)
 			if IsErrType(err, NoNode) {
 				log.Warningf("GetShard(%v, %v) returned ErrNoNode, consider checking the topology.", keyspace, shard)
 			} else {
-				vterrors.Wrapf(err, "GetShard(%v, %v) failed", keyspace, shard)
+				return nil, vterrors.Wrapf(err, "GetShard(%v, %v) failed", keyspace, shard)
 			}
 		}
 		result[shard] = si