update make target

Signed-off-by: Andres Taylor <[email protected]>

.github/workflows/check_make_visitor.yml

@@ -31,5 +31,5 @@ jobs:
 
     - name: check_make_visitor
       run: |
-        misc/git/hooks/visitorgen
+        misc/git/hooks/asthelpers
 

Makefile

@@ -103,6 +103,10 @@ parser:
 	make -C go/vt/sqlparser
 
 visitor:
+	>&2 echo "make visitor has been replaced by make asthelpers"
+	exit 1
+
+asthelpers:
 	go run ./go/tools/asthelpergen/main -in ./go/vt/sqlparser -iface vitess.io/vitess/go/vt/sqlparser.SQLNode -except "*ColName"
 
 sizegen:
@@ -123,7 +127,6 @@ clean:
 	go clean -i ./go/...
 	rm -rf third_party/acolyte
 	rm -rf go/vt/.proto.tmp
-	rm -rf ./visitorgen
 
 # Remove everything including stuff pulled down by bootstrap.sh
 cleanall: clean

go/vt/sqlparser/walker_test.go

@@ -40,9 +40,9 @@ func BenchmarkWalkLargeExpression(b *testing.B) {
 }
 
 func BenchmarkRewriteLargeExpression(b *testing.B) {
-	for i := 0; i < 10; i++ {
+	for i := 1; i < 7; i++ {
 		b.Run(fmt.Sprintf("%d", i), func(b *testing.B) {
-			exp := newGenerator(int64(i*100), 5).expression()
+			exp := newGenerator(int64(i*100), i).expression()
 			count := 0
 			for i := 0; i < b.N; i++ {
 				_, err := Rewrite(exp, func(_ *Cursor) bool {