Read cytokit csv #77
Read cytokit csv #77
Conversation
|
(Sorry, need to update fixture...) |
There was a problem hiding this comment.
This looks good to me. I don't think we've added Arrow things into vitessce yet. I will explore generating arrow and comparing file sizes if that's something we are running into. Feel free to merge this and then I'll take a look tomorrow with Arrow.
If you could comment on how large the output currently is, that would be helpful for tomorrow.
|
|
||
|
|
||
| def round_conv(s): | ||
| # TODO: Truncating after decimal point might be slightly too aggressive? |
There was a problem hiding this comment.
I'll look into this with Arrow and compare file sizes.
There was a problem hiding this comment.
Perhaps for the x and y coordinates, we should have some precision beyond the decimal point, but I'm not convinced for the gene "levels" this is necessary.
scripts/process_cytokit.sh
Outdated
|
|
||
| main() { | ||
| # Download and process data which describes cell locations, | ||
| # and gene expression levels. Multiple JSON output files are produced: |
There was a problem hiding this comment.
Will there be more output files than just cells.json?
This is preparatory to hubmapconsortium/portal-containers#14
As discussed, the document is large enough that it might be useful to use Arrow.