-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(css): include inline css module in bundle (fix #6984,#7552) #7591
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks also for expanding the condition. It is interesting that we have been returning modulesCode
even when it is not used, this could potentially fix other issues (like duplicated CSS that esbuild has issues tree-shacking).
We can do it in another PR, but we may want to create a getModulesCode()
function so we can call it for the dev branch, but only for the build branch when it is actually going to be needed.
may be there are same with #6996 ? 👀 |
Oh I failed to find your PR. I think this PR is same with it. |
may be this PR cover my test 😊. so let it forward. |
Description
This PR fixes #7552.
The issue title mentions SCSS, but it also happens with CSS.
fixes #6984
fixes #7552
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).