-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: clarify code comments in optimize-missing-deps
#7332
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry I wrote this confusing note, which contains a stale story about "built-in deps". Your changes are correct to make it clearer, thank you!
In addition, the main purpose of optimize-missing-deps
is to test that _registerMissingImport
is not triggered during SSR. You can see the reason and my detailed description at #5017 (comment). Hope it helps you understand.
@ygj6 Do you know why the test is failing (https://github.com/vitejs/vite/pull/6698/checks) when externalizing SSR dependencies (#6698)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonder if this description is more concise. I find the current one a bit off 😅
Co-authored-by: Bjorn Lu <[email protected]>
This reverts commit 05bd213.
Co-authored-by: Bjorn Lu <[email protected]>
Co-authored-by: Bjorn Lu <[email protected]>
Description
I didn't understand that "missing" meant not discovered. Also, the sentence "this will import missing deps nest built-in deps" seems like it has a typo because it doesn't make sense
Please check that what I've written is correct
Additional context
This test was failing when I was working on another change and I wanted to better understand it
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).