Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve alias merging #6497

Merged
merged 2 commits into from
Jan 13, 2022
Merged

fix: improve alias merging #6497

merged 2 commits into from
Jan 13, 2022

Conversation

antfu
Copy link
Member

@antfu antfu commented Jan 13, 2022

Description

Changes in #6344 expose the problem of alias merging strategy.

E.g.

mergeConfig(
  {
    resolve: { alias: { foo: 'old' }}
  },
  {
    resolve: { alias: { foo: 'new' }}
  }
)

With will be normalized to

[
  { find: 'foo', replacement: 'old' },
  { find: 'foo', replacement: 'new' }
]

Since @rollup/plugin-alias resolve the alias from top-down, it makes foo always resolved to foo, and makes the later config fail to override the previous.

Leading the error in Nuxt: nuxt/framework#2716

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@antfu antfu added the p3-minor-bug An edge case that only affects very specific usage (priority) label Jan 13, 2022
if (!a) return b
if (!b) return a
if (isObject(a) && isObject(b)) {
return { ...a, ...b }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The order here isn't important?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

B should override A, which is the behavior of object merging, but not array previously

@antfu antfu merged commit e57d8c6 into main Jan 13, 2022
@antfu antfu deleted the fix/resolve-alias branch January 13, 2022 19:22
antfu added a commit that referenced this pull request Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants