Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use hires: true for SSR require hook source map #6310

Merged
merged 1 commit into from
Dec 30, 2021
Merged

fix: use hires: true for SSR require hook source map #6310

merged 1 commit into from
Dec 30, 2021

Conversation

Monkatraz
Copy link
Contributor

Description

I believe this is the one spot in the Vite codebase where hires: true was missed.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@patak-dev patak-dev merged commit 0ebeb98 into vitejs:main Dec 30, 2021
antfu pushed a commit that referenced this pull request Dec 30, 2021
@Monkatraz @antfu
fix: use hires: true for SSR require hook source map (#6310)
6231f9f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

@antfu antfu antfu approved these changes

@patak-dev patak-dev patak-dev approved these changes

Assignees
No one assigned
Labels
feat: ssr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Monkatraz @patak-dev @antfu @bluwy @Niputi