-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: plugin hooks ssr param to object #5253
Conversation
LGTM (Superficial review. Neat comprehensive docs update 👌.), and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to release this with 2.7, or before?
You could add this PR to the milestone dependant on the answer 🙂
I didnt add it yet because I dont know if we are targetting 2.7 or 2.8. But given the way the ecosystem reacted, it is probably going to be in the next minor |
Adds backwards compatible handling of the plugin API changes from Vite 2.7 (vitejs/vite#5253)
Description
See discussion at #5109 (comment).
This PR modifies the way Vite informs
ssr
mode to plugin hooks from a positional param to a prop in theoptions
object ofresolveId
,transform
andload
. This was already discussed by the team and the plugin authors.What is the purpose of this pull request?