Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add type any to parameter e/err/err2, resolve ts error #4972

Closed
wants to merge 1 commit into from

Conversation

btea
Copy link
Collaborator

@btea btea commented Sep 18, 2021

Description

add type any to catch parameter to resolve ts error

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link
Member

@haoqunjiang haoqunjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any TS errors.
And enabling useUnknownInCatchVariables (pending #4932) is obviously a better choice than explicit anys.

Copy link
Member

@haoqunjiang haoqunjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh now I see the errors, when choosing VS Code's built-in TS version.

I think it's better to add instance of Error guard in the error handlers than explicit anys.

@Shinigami92
Copy link
Member

This is not the right way, we already have a PR for bringing TS 4.4 support and tracking api-extractor support here: #4932

@btea btea deleted the fix-add-e-type branch September 18, 2021 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants