Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: patch local vitepress for docs build #3323

Closed
wants to merge 1 commit into from

Conversation

antfu
Copy link
Member

@antfu antfu commented May 9, 2021

Description

The local vitepress build for docs is failing because of the removal of vite/dynamic-import-polyfill in #2976. This PR patch vitepress to make the docs success. Later on when we released v2.3, we will also release a new version and vitepress then remove the patch.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@patak-dev
Copy link
Member

Alternative PR following our discussion here #3328

@antfu antfu closed this May 10, 2021
@antfu antfu deleted the fix/patch-vitepress branch May 10, 2021 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants