fix(ssr): named export should overwrite export all #19534

hi-ogawa · 2025-02-28T01:28:23Z

Description

Closes Vite SSR doesn't overwrite * re-export by named export #19525 (comment)

This change should also help when named export is hoisted in #18983.

hi-ogawa · 2025-02-28T01:41:27Z

packages/vite/src/node/ssr/__tests__/ssrLoadModule.spec.ts

+  // ESM spec doesn't allow conflicting `export *` and such duplicate exports are removed (in this case "d"),
+  // but this is likely not possible to support due to Vite dev SSR's lazy nature.
+  // [Node]
+  //   $ node -e 'import("./packages/vite/src/node/ssr/__tests__/fixtures/named-overwrite-all/main.js").then(console.log)'
+  //   [Module: null prototype] { a: 'main-a', b: 'dep1-b', c: 'main-c' }
+  // [Rollup]
+  //   Conflicting namespaces: "main.js" re-exports "d" from one of the modules "dep1.js" and "dep2.js" (will be ignored).
+  expect(mod).toMatchInlineSnapshot(`
+    {
+      "a": "main-a",
+      "b": "dep1-b",
+      "c": "main-c",
+      "d": "dep1-d",
+    }
+  `)


I just learned that ESM spec says duplicate names from export * from ... should be removed entirely 😮 (Didn't actually read the spec but it's on MDN https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/export#specifications:~:text=If%20there%20are%20two%20wildcard%20exports%20statements%20that%20implicitly%20re%2Dexport%20the%20same%20name%2C%20neither%20one%20is%20re%2Dexported.)

I think this case is hard to handle on Vite SSR model, so the behavior here is that first export * wins.

hi-ogawa · 2025-02-28T01:42:17Z

/ecosystem-ci run

pkg-pr-new · 2025-02-28T01:43:16Z

Open in Stackblitz

npm i https://pkg.pr.new/vite@19534

commit: 7748fc7

vite-ecosystem-ci · 2025-02-28T01:58:58Z

📝 Ran ecosystem CI on 7748fc7: Open

suite	result	latest scheduled
astro	❌ failure	❌ failure
nuxt	❌ failure	✅ success
vike	❌ failure	✅ success
vite-plugin-svelte	❌ failure	❌ failure

✅ quasar, histoire, laravel, ladle, analogjs, vite-plugin-react, vite-plugin-pwa, sveltekit, rakkas, vite-environment-examples, react-router, previewjs, marko, unocss, qwik, storybook, vuepress, vitepress, vitest, vite-plugin-cloudflare, waku, vite-setup-catalogue, vite-plugin-react-swc, vite-plugin-vue

vite-ecosystem-ci · 2025-02-28T02:22:17Z

📝 Ran ecosystem CI on 7748fc7: Open

suite	result	latest scheduled
astro	❌ failure	❌ failure
nuxt	❌ failure	✅ success
vite-plugin-svelte	❌ failure	❌ failure

✅ analogjs, laravel, qwik, histoire, unocss, storybook, previewjs, react-router, vike, rakkas, vite-setup-catalogue, vitepress, vite-plugin-vue, vite-environment-examples, sveltekit, vite-plugin-react, quasar, vite-plugin-react-swc, vite-plugin-cloudflare, vuepress, vite-plugin-pwa, waku, vitest, marko, ladle

vite-ecosystem-ci · 2025-02-28T02:37:12Z

📝 Ran ecosystem CI on 7748fc7: Open

suite	result	latest scheduled
vite-plugin-svelte	❌ failure	❌ failure
astro	❌ failure	❌ failure

✅ ladle, previewjs, marko, analogjs, vike, unocss, laravel, vite-plugin-react, histoire, sveltekit, vite-plugin-react-swc, vite-environment-examples, qwik, vite-setup-catalogue, rakkas, react-router, vite-plugin-pwa, quasar, nuxt, vite-plugin-vue, storybook, vite-plugin-cloudflare, vuepress, vitest, vitepress, waku

| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | vite | 6.1.0 | 6.2.1 | ## [v6.2.1](https://github.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#small621-2025-03-07-small) - refactor: remove `isBuild` check from preAliasPlugin ([#19587](vitejs/vite#19587)) ([c9e086d](vitejs/vite@c9e086d)), closes [#19587](vitejs/vite#19587) - refactor: restore endsWith usage ([#19554](vitejs/vite#19554)) ([6113a96](vitejs/vite@6113a96)), closes [#19554](vitejs/vite#19554) - refactor: use `applyToEnvironment` in internal plugins ([#19588](vitejs/vite#19588)) ([f678442](vitejs/vite@f678442)), closes [#19588](vitejs/vite#19588) - fix(css): stabilize css module hashes with lightningcss in dev mode ([#19481](vitejs/vite#19481)) ([92125b4](vitejs/vite@92125b4)), closes [#19481](vitejs/vite#19481) - fix(deps): update all non-major dependencies ([#19555](vitejs/vite#19555)) ([f612e0f](vitejs/vite@f612e0f)), closes [#19555](vitejs/vite#19555) - fix(reporter): fix incorrect bundle size calculation with non-ASCII characters ([#19561](vitejs/vite#19561)) ([437c0ed](vitejs/vite@437c0ed)), closes [#19561](vitejs/vite#19561) - fix(sourcemap): combine sourcemaps with multiple sources without matched source ([#18971](vitejs/vite#18971)) ([e3f6ae1](vitejs/vite@e3f6ae1)), closes [#18971](vitejs/vite#18971) - fix(ssr): named export should overwrite export all ([#19534](vitejs/vite#19534)) ([2fd2fc1](vitejs/vite@2fd2fc1)), closes [#19534](vitejs/vite#19534) - feat: add `*?url&no-inline` type and warning for `.json?inline` / `.json?no-inline` ([#19566](vitejs/vite#19566)) ([c0d3667](vitejs/vite@c0d3667)), closes [#19566](vitejs/vite#19566) - test: add glob import test case ([#19516](vitejs/vite#19516)) ([aa1d807](vitejs/vite@aa1d807)), closes [#19516](vitejs/vite#19516) - test: convert config playground to unit tests ([#19568](vitejs/vite#19568)) ([c0e68da](vitejs/vite@c0e68da)), closes [#19568](vitejs/vite#19568) - test: convert resolve-config playground to unit tests ([#19567](vitejs/vite#19567)) ([db5fb48](vitejs/vite@db5fb48)), closes [#19567](vitejs/vite#19567) - perf: flush compile cache after 10s ([#19537](vitejs/vite#19537)) ([6c8a5a2](vitejs/vite@6c8a5a2)), closes [#19537](vitejs/vite#19537) - chore(css): move environment destructuring after condition check ([#19492](vitejs/vite#19492)) ([c9eda23](vitejs/vite@c9eda23)), closes [#19492](vitejs/vite#19492) - chore(html): remove unnecessary value check ([#19491](vitejs/vite#19491)) ([797959f](vitejs/vite@797959f)), closes [#19491](vitejs/vite#19491) ## [v6.2.0](https://github.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#620-2025-02-25) - fix(deps): update all non-major dependencies ([#19501](vitejs/vite#19501)) ([c94c9e0](vitejs/vite@c94c9e0)), closes [#19501](vitejs/vite#19501) - fix(worker): string interpolation in dynamic worker options ([#19476](vitejs/vite#19476)) ([07091a1](vitejs/vite@07091a1)), closes [#19476](vitejs/vite#19476) - chore: use unicode cross icon instead of x ([#19497](vitejs/vite#19497)) ([5c70296](vitejs/vite@5c70296)), closes [#19497](vitejs/vite#19497) ## [v6.1.1](https://github.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#small611-2025-02-19-small) - fix: ensure `.[cm]?[tj]sx?` static assets are JS mime ([#19453](vitejs/vite#19453)) ([e7ba55e](vitejs/vite@e7ba55e)), closes [#19453](vitejs/vite#19453) - fix: ignore `*.ipv4` address in cert ([#19416](vitejs/vite#19416)) ([973283b](vitejs/vite@973283b)), closes [#19416](vitejs/vite#19416) - fix(css): run rewrite plugin if postcss plugin exists ([#19371](vitejs/vite#19371)) ([bcdb51a](vitejs/vite@bcdb51a)), closes [#19371](vitejs/vite#19371) - fix(deps): bump tsconfck ([#19375](vitejs/vite#19375)) ([746a583](vitejs/vite@746a583)), closes [#19375](vitejs/vite#19375) - fix(deps): update all non-major dependencies ([#19392](vitejs/vite#19392)) ([60456a5](vitejs/vite@60456a5)), closes [#19392](vitejs/vite#19392) - fix(deps): update all non-major dependencies ([#19440](vitejs/vite#19440)) ([ccac73d](vitejs/vite@ccac73d)), closes [#19440](vitejs/vite#19440) - fix(html): ignore malformed src attrs ([#19397](vitejs/vite#19397)) ([aff7812](vitejs/vite@aff7812)), closes [#19397](vitejs/vite#19397) - fix(worker): fix web worker type detection ([#19462](vitejs/vite#19462)) ([edc65ea](vitejs/vite@edc65ea)), closes [#19462](vitejs/vite#19462) - refactor: remove custom .jxl mime ([#19457](vitejs/vite#19457)) ([0c85464](vitejs/vite@0c85464)), closes [#19457](vitejs/vite#19457) - feat: add support for injecting debug IDs ([#18763](vitejs/vite#18763)) ([0ff556a](vitejs/vite@0ff556a)), closes [#18763](vitejs/vite#18763) - chore: update 6.1.0 changelog ([#19363](vitejs/vite#19363)) ([fa7c211](vitejs/vite@fa7c211)), closes [#19363](vitejs/vite#19363)

fix(ssr): named export should overwrites export all

7748fc7

hi-ogawa mentioned this pull request Feb 28, 2025

Vite SSR doesn't overwrite * re-export by named export #19525

Closed

7 tasks

hi-ogawa commented Feb 28, 2025

View reviewed changes

vite-ecosystem-ci bot added the trigger: preview label Feb 28, 2025

hi-ogawa changed the title ~~fix(ssr): named export should overwrites export all~~ fix(ssr): named export should overwrite export all Feb 28, 2025

hi-ogawa marked this pull request as ready for review February 28, 2025 03:16

sapphi-red approved these changes Feb 28, 2025

View reviewed changes

sapphi-red added p3-minor-bug An edge case that only affects very specific usage (priority) feat: ssr labels Feb 28, 2025

patak-dev approved these changes Mar 2, 2025

View reviewed changes

patak-dev merged commit 2fd2fc1 into vitejs:main Mar 2, 2025
21 checks passed

hi-ogawa deleted the fix-named-export-vs-export-all branch March 2, 2025 23:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(ssr): named export should overwrite export all #19534

fix(ssr): named export should overwrite export all #19534

hi-ogawa commented Feb 28, 2025 •

edited

Loading

hi-ogawa Feb 28, 2025

hi-ogawa commented Feb 28, 2025

pkg-pr-new bot commented Feb 28, 2025 •

edited

Loading

vite-ecosystem-ci bot commented Feb 28, 2025

vite-ecosystem-ci bot commented Feb 28, 2025

vite-ecosystem-ci bot commented Feb 28, 2025

fix(ssr): named export should overwrite export all #19534

fix(ssr): named export should overwrite export all #19534

Conversation

hi-ogawa commented Feb 28, 2025 • edited Loading

Description

hi-ogawa Feb 28, 2025

Choose a reason for hiding this comment

hi-ogawa commented Feb 28, 2025

pkg-pr-new bot commented Feb 28, 2025 • edited Loading

vite-ecosystem-ci bot commented Feb 28, 2025

vite-ecosystem-ci bot commented Feb 28, 2025

vite-ecosystem-ci bot commented Feb 28, 2025

hi-ogawa commented Feb 28, 2025 •

edited

Loading

pkg-pr-new bot commented Feb 28, 2025 •

edited

Loading