Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for .jxl #18855

Merged
merged 4 commits into from
Jan 23, 2025
Merged

feat: add support for .jxl #18855

merged 4 commits into from
Jan 23, 2025

Conversation

yuxi-ovo
Copy link
Contributor

@yuxi-ovo yuxi-ovo commented Dec 2, 2024

fixes #18835

@sapphi-red sapphi-red changed the title chore(node/constants): add jxl support feat: add support for .jxl Dec 2, 2024
sapphi-red
sapphi-red requested changes Dec 2, 2024
View reviewed changes
@sapphi-red sapphi-red added the p2-nice-to-have Not breaking anything but nice to have (priority) label Dec 2, 2024
@yuxi-ovo yuxi-ovo requested a review from sapphi-red December 2, 2024 12:07
bluwy
bluwy previously approved these changes Dec 2, 2024
View reviewed changes
@bluwy bluwy added this to the 6.1 milestone Dec 2, 2024
@atjn atjn mentioned this pull request Dec 2, 2024
Closed
sapphi-red
sapphi-red approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@patak-dev patak-dev merged commit 57b397c into vitejs:main Jan 23, 2025
15 checks passed
@lukeed
Copy link
Contributor

lukeed commented Feb 17, 2025 •
edited
Loading

[email protected] was released which includes jxl by default, among others.

The update also includes mts -> video/mp2t so i ran the checked the Vite tests & setup a playground.. everything still seems to work ok. There always was a ts -> video/mp2t mime, so it looks like the existing overrides in place are catching mts too 👍

edit 1: nvm. imports work, but when served from static/assets dir, it doesnt. sending PR

edit 2: actually, static mts files didn't work beforehand anyway. they were always sent w/ blank Content-Type

@lukeed lukeed mentioned this pull request Feb 17, 2025
Merged
@sapphi-red sapphi-red mentioned this pull request Feb 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

@sapphi-red sapphi-red sapphi-red approved these changes

@Sec32fun32 Sec32fun32 Sec32fun32 approved these changes

@bluwy bluwy bluwy left review comments

Assignees
No one assigned
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Milestone
6.1
Development

Successfully merging this pull request may close these issues.

Support Jpeg XL images in static handling
6 participants
@yuxi-ovo @lukeed @patak-dev @bluwy @sapphi-red @Sec32fun32