Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include more modules to prefix-only module list #18667

Merged
merged 1 commit into from
Nov 14, 2024
Merged

fix: include more modules to prefix-only module list #18667

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/vite/src/module-runner/evaluatedModules.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,13 @@ export class EvaluatedModules {
}

// unique id that is not available as "$bare_import" like "test"
const prefixedBuiltins = new Set(['node:test', 'node:sqlite'])
// https://nodejs.org/api/modules.html#built-in-modules-with-mandatory-node-prefix
const prefixedBuiltins = new Set([
'node:sea',
'node:sqlite',
Copy link
Member Author

@sapphi-red sapphi-red Nov 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not on the list in the link, but this is also a prefix-only module (https://nodejs.org/docs/latest/api/sqlite.html#:~:text=This%20module%20is%20only%20available%20under%20the%20node%3A%20scheme.%20The%20following%20will%20not%20work%3A).

'node:test',
'node:test/reporters',
])

// transform file url to id
// virtual:custom -> virtual:custom
Expand Down