Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass customLogger to loadConfigFromFile (fix #15824) #15831

Merged

Conversation

nedjulius
Copy link
Contributor

Description

This PR fixes #15824

Basically, it passes down the customLogger and clearScreen options from inline build config to loadConfigFromFile function where they can be utilized if read from file fails.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link

stackblitz bot commented Feb 7, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@nedjulius
Copy link
Contributor Author

seems like one test flaked?

no related changes to the failed test.

Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We also need to update the docs here:

## `loadConfigFromFile`

packages/vite/src/node/config.ts Outdated Show resolved Hide resolved
@bluwy bluwy added the p3-minor-bug An edge case that only affects very specific usage (priority) label Feb 8, 2024
@patak-dev patak-dev merged commit 55a3427 into vitejs:main Feb 8, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

customLogger option ignored when logging "failed to load config from..." errors
3 participants