fix(ssr): mark builtin modules as side effect free #15658
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently all builtin modules are mark as a side-effect by default. This PR forces them as side-effect-free so they don't get imported if the code that uses it got treeshaken away.
While I think it's hard to guarantee all builtin modules (including deno and bun) in the future will remain side-effect free, I think it's probably a safe assumption for now, and we can manually mark those that are not in the future in a non-breaking way.
Having this optimization will help bundling libraries or code that may accidentally reference node builtins, but are not actually using it. There is the valid argument that the code shouldn't have referenced them in the first place though 🤔
Additional context
similar esbuild issue: evanw/esbuild#705
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).