Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): support @rollup/plugin-auto-install #1512

Closed
wants to merge 2 commits into from

Conversation

underfin
Copy link
Member

fix #1500

@yyx990803
Copy link
Member

This will break manual polyfill import when using non-html entry points: https://vitejs.dev/guide/backend-integration.html

@underfin
Copy link
Member Author

I add waring for vite/dynamic-import-polyfill usage.

@patak-dev
Copy link
Member

@underfin do you think something else is needed to be able to merge this PR?

@patak-dev
Copy link
Member

I updated the repro to the latest version: https://github.com/patak-js/vite-rollup-plugin-auto-install, but I am still seeing an issue when building

λ yarn build
yarn run v1.22.10
$ vite build
vite v2.1.3 building for production...
transforming (1) index.htmlinstalling vite...
installing @vue/runtime-dom...
transforming (5) src\components\HelloWorld.vueinstalling nanoid...
✓ 9 modules transformed.
[auto-install] Command failed: yarn add nanoid
warning " > @rollup/[email protected]" has unmet peer dependency "rollup@^1.20.0||^2.0.0".
error An unexpected error occurred: "EPERM: operation not permitted, unlink 'C:\\Labs\\vite-rollup-plugin-auto-install\\node_modules\\esbuild\\esbuild.exe'".

error during build:
Error: Command failed: yarn add nanoid
warning " > @rollup/[email protected]" has unmet peer dependency "rollup@^1.20.0||^2.0.0".
error An unexpected error occurred: "EPERM: operation not permitted, unlink 'C:\\Labs\\vite-rollup-plugin-auto-install\\node_modules\\esbuild\\esbuild.exe'".

    at ChildProcess.exithandler (node:child_process:326:12)
    at ChildProcess.emit (node:events:369:20)
    at maybeClose (node:internal/child_process:1067:16)
    at Process.ChildProcess._handle.onexit (node:internal/child_process:301:5)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

If I understand correctly, this will require a minor version bump if merged.

@antfu antfu marked this pull request as draft April 27, 2021 10:22
@antfu antfu closed this Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@rollup/plugin-auto-install + vue failing at build time
4 participants