revert: fix: disable keepNames in vite:esbuild (fixes #9164) #14616
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit e6f3b02 to fix #13727.
Description
It is possible for esbuild to rename symbols even if it is not minifying.
But in order for tree-shaking to properly work, we disabled
keepNames
invite:esbuild
phase, which let renaming. One proof of concept shows it actually renames and causes a problem like in #13727.Therefore we should let
keepNames
be respected again invite:esbuild
phase.Additional context
Tree-shaking is about file size while
keepNames
is about the real logic that matters. I think it's an enough reason to revert a commit.What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).