Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: fix: disable keepNames in vite:esbuild (fixes #9164) #14616

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

TrulyBright
Copy link

@TrulyBright TrulyBright commented Oct 13, 2023

This reverts commit e6f3b02 to fix #13727.

Description

It is possible for esbuild to rename symbols even if it is not minifying.
But in order for tree-shaking to properly work, we disabled keepNames in vite:esbuild phase, which let renaming. One proof of concept shows it actually renames and causes a problem like in #13727.
Therefore we should let keepNames be respected again in vite:esbuild phase.

Additional context

Tree-shaking is about file size while keepNames is about the real logic that matters. I think it's an enough reason to revert a commit.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@illegalnumbers
Copy link

Is anyone looking at this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

esbuild keepNames not respected
2 participants