fix(html): import expression in classic script for dev #14595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapphi-red
added
feat: html
p3-minor-bug
sapphi-red
commented
Oct 12, 2023
Comment on lines
-242
to
+245
| // use resolved port/base from server | ||
| const devBase = server.config.base | ||
| viteTestUrl = `http://localhost:${server.config.server.port}${ | ||
| devBase === '/' ? '' : devBase | ||
| }` | ||
| viteTestUrl = server.resolvedUrls.local[0] | ||
| if (server.config.base === '/') { | ||
| viteTestUrl = viteTestUrl.replace(/\/$/, '') | ||
| } |
There was a problem hiding this comment.
assets playground has base: '/foo/bar' but playwright was accessing http://localhost:5173/foo/bar/ instead of http://localhost:5173/foo/bar.
patak-dev
previously approved these changes
Oct 12, 2023
sapphi-red
dismissed
patak-dev’s stale review
The merge-base changed after approval.
sapphi-red
force-pushed
the
fix/html-import-expression-in-classic-script-for-dev
branch
from
db2d7f2
to
f1e5d17
Compare
|
Rebased on main to resolve conflict with #14592. |
patak-dev
approved these changes
Oct 12, 2023
sapphi-red
deleted the
fix/html-import-expression-in-classic-script-for-dev
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes changes from #14592 (otherwise, the tests fail)Support for
importexpressions in classic script (added by #6525) was not working for dev.This PR fixes that.
This bug was found at #5657 (comment).
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).