Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: v4 to v5 migration guide #14343

Merged
merged 6 commits into from
Sep 30, 2023
Merged

docs: v4 to v5 migration guide #14343

merged 6 commits into from
Sep 30, 2023

Conversation

sapphi-red
Copy link
Member

Description

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the documentation Improvements or additions to documentation label Sep 10, 2023
@stackblitz
Copy link

stackblitz bot commented Sep 10, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@vite-ecosystem-ci

This comment was marked as off-topic.

Sign in to view
@sapphi-red sapphi-red mentioned this pull request Sep 15, 2023
Merged
1 task
sapphi-red
sapphi-red commented Sep 23, 2023
View reviewed changes
docs/guide/migration.md Outdated Show resolved Hide resolved
@sapphi-red sapphi-red added this to the 5.0 milestone Sep 23, 2023
@sapphi-red sapphi-red marked this pull request as ready for review September 25, 2023 08:25
patak-dev
patak-dev reviewed Sep 25, 2023
View reviewed changes
docs/guide/migration.md Outdated Show resolved Hide resolved
patak-dev
patak-dev approved these changes Sep 30, 2023
View reviewed changes
Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this one could be merged, and then others can include changes in their PRs as part of the docs updates too

@patak-dev patak-dev merged commit 5e98fe7 into vitejs:main Sep 30, 2023
9 checks passed
@sapphi-red sapphi-red deleted the docs/migration-guide branch September 30, 2023 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btea btea btea left review comments

@patak-dev patak-dev patak-dev approved these changes

@bluwy bluwy Awaiting requested review from bluwy

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@sapphi-red @patak-dev @btea @bluwy