Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(build): remove warning about ineffective dynamic import from node_modules #13884

Merged
merged 8 commits into from
Jul 20, 2023
+5 −4
Merged

fix(build): remove warning about ineffective dynamic import from node_modules #13884

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e0f49a7
feat(node): remove warning about ineffective dynamic import of node_m…
chaejunlee Jul 17, 2023
135e9d6
feat(node): add config option of `warnExternalChunkRender`
chaejunlee Jul 18, 2023
4b9ffeb
fix(node): optionalize `warnExternalChunkRender`
chaejunlee Jul 18, 2023
33bca87
docs(config): add information about `build.warnExternalChunkRender`
chaejunlee Jul 20, 2023
26a49ef
fix(node): remove config option `warnExternalChunkRender`
chaejunlee Jul 20, 2023
c62b9da
fix(node): conform with the conventions
chaejunlee Jul 20, 2023
3e8736d
fix(node): remove unnecessary type assertion
chaejunlee Jul 20, 2023
7dc2085
fix(node): change back conditional to how it was
chaejunlee Jul 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions packages/vite/src/node/plugins/reporter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { promisify } from 'node:util'
import colors from 'picocolors'
import type { Plugin } from 'rollup'
import type { ResolvedConfig } from '../config'
import { isDefined, normalizePath } from '../utils'
import { isDefined, isInNodeModules, normalizePath } from '../utils'
import { LogLevels } from '../logger'

const groups = [
Expand Down Expand Up @@ -122,9 +122,10 @@ export function buildReporterPlugin(config: ResolvedConfig): Plugin {
// the same chunk. The intersecting dynamic importers' dynamic import is not
// expected to work. Note we're only detecting the direct ineffective
// dynamic import here.
if (
module.dynamicImporters.some((m) => chunk.moduleIds.includes(m))
) {
const detectedIneffectiveDynamicImport = module.dynamicImporters.some(
(id) => !isInNodeModules(id) && chunk.moduleIds.includes(id),
)
if (detectedIneffectiveDynamicImport) {
this.warn(
`\n(!) ${
module.id
Expand Down