Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: should exit when build-types-check failed #12378

Merged
merged 1 commit into from
Mar 12, 2023

Conversation

fi3ework
Copy link
Member

Description

In pull request #11195 of https://github.com/vitejs/vite, build-types-check was introduced to prevent importing types from devDeps in dist types. However, it does not cause the CI to fail when detecting an error. Is there a reason for this? 🤔 cc author @sapphi-red

This is exemplified by a real case:
Detected an error in https://github.com/vitejs/vite/actions/runs/4245724684/jobs/7381608885#step:11:70 but not throw which needs #12346 to fix it afterward.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz
Copy link

stackblitz bot commented Mar 12, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@sapphi-red sapphi-red added the p1-chore Doesn't change code behavior (priority) label Mar 12, 2023
Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks.
I just simply forgot about that 😅

@patak-dev patak-dev merged commit 821d6b8 into vitejs:main Mar 12, 2023
@fi3ework fi3ework deleted the fail-check-type branch March 12, 2023 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants