fix(preview): Revert #10564 - throw Error on missing outDir #11335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…how 404s due to nonexistent build (vitejs#10564)" This reverts commit 0a1db8c
patak-dev
approved these changes
Dec 12, 2022
futurGH
pushed a commit
to futurGH/vite
that referenced
this pull request
Feb 26, 2023
…tejs#11335) fix(preview): Revert "fix: check if build exists so preview doesn't show 404s due to nonexistent build (vitejs#10564)" This reverts commit 0a1db8c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 0a1db8c
configurePreviewServercan be used to make it work regardless of that directory existing, throwing the Error that wasn't there before is a breaking change.see for details #10564 (comment)
Description
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).