fix(mpa): support mpa fallback #10985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the docs would need to be updated: https://vitejs.dev/config/shared-options.html#apptype |
|
@brillout you might be interested in taking a look at this PR |
bluwy
approved these changes
Nov 19, 2022
bluwy
added
feat: html
p3-minor-bug
|
What’s the difference between returning undefined and returning request.url? |
|
Undefined will crash the server instead of calling |
sapphi-red
approved these changes
Nov 20, 2022
|
@benmccann would you do another PR modifying the docs if you see something to improve there? I don't see references to the fallback right now there that should be updated. |
👍 I don't see any objections then. |
bluwy
pushed a commit
that referenced
this pull request
Nov 29, 2022
patak-dev
pushed a commit
that referenced
this pull request
Nov 30, 2022
* fix(config): exclude config.assetsInclude empty array (#10941) fixes #10926 * feat(css): upgrade postcss-modules (#10987) * fix(mpa): support mpa fallback (#10985) fixes #10966 * fix: export preprocessCSS in CJS (#11067) * chore: update license Co-authored-by: sun0day <[email protected]> Co-authored-by: Jason Quense <[email protected]> Co-authored-by: sun0day <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes #10966
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).