You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the old version of "esbuild", in order to flatten the dependent pre built products, the agent module will be used to process the "require ('react /jsx runtime. js')" The reason why the path was not directly modified to redirect to the entry is that the products will have a nested structure. The subsequent packaging is also added to prevent secondary packaging.
However, for the current version of "esbuild", even if it is directly redirected to the entry module, the product name is still specified by entryPoints and will not result in secondary packaging or nested products. Therefore, we do not need to use the proxy module now.
After the above code is deleted and added, vite still runs well, and the pre built products and product size will not change. Even if module "A" depends on module "B", using modules "A" and "B" in the project can also extract the same part.
Deleting the agent module will optimize more volumes.
For the old version of "esbuild", in order to flatten the dependent pre built products, the agent module will be used to process the "require ('react /jsx runtime. js')". The reason why the path was not directly modified to redirect to the entry is that the products will have a nested structure. The subsequent wrapper is also added to prevent secondary packaging.
However, for the current version of "esbuild", even if it is directly redirected to the entry module, the product name is still specified by "entryPoints" and will not result in secondary packaging or nested products. Therefore, we do not need to use the proxy module now.
After deleting and adding the above code, “vite” still runs well, and the pre built product and product size will not change.
If the "0.8.34" version of "esbuild" is used for packaging, and the path is directly modified, the nesting problem of the "dist" directory will occur.
Therefore, "onLoad" is introduced to load modules so that the products will not be nested. However, this may lead to the problem of secondary packaging. Therefore, 'es module lexer' is used to scan the entry file and generate new content of the package as the return value of "contents".
However, for the current version of "esbuild", even if the path is directly modified, the problem of product nesting will not occur
So you can delete the proxy module. The comment in the source code is this paragraph:
And you can also extract the same module by directly modifying the path in current version of "esbuild"
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ysy945
changed the title
patak-dev
changed the title
For the old version of "esbuild", in order to flatten the dependent pre built products, the agent module will be used to process the "require ('react /jsx runtime. js')" The reason why the path was not directly modified to redirect to the entry is that the products will have a nested structure. The subsequent packaging is also added to prevent secondary packaging.
However, for the current version of "esbuild", even if it is directly redirected to the entry module, the product name is still specified by entryPoints and will not result in secondary packaging or nested products. Therefore, we do not need to use the proxy module now.
After the above code is deleted and added, vite still runs well, and the pre built products and product size will not change. Even if module "A" depends on module "B", using modules "A" and "B" in the project can also extract the same part.
Deleting the agent module will optimize more volumes.