fix: optimizeDeps.include
not working with paths inside packages
#13922
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently using something like:
doesn't work consistently across projects. In case of monorepos, it fails to resolve deps when the include contains some path other than the package name itself - (e.g.
@vueuse/integrations/useFocusTrap
andmark.js/src/vanilla.js
in this case). It works fine forminisearch
because that's the package name itself.The cause of this issue seems to be the fact that
tryOptimizedResolve
callsresolvePackageData
withid
instead of package name (e.g.@vueuse/integrations/useFocusTrap
instead of@vueuse/integrations
). Which results inresolvePackageData
searching for package.json in wrong directories (e.g.'/Users/brc-dd/vitepress/node_modules/@vueuse/integrations/useFocusTrap/package.json'
instead of'/Users/brc-dd/vitepress/node_modules/@vueuse/integrations/package.json'
).This PR fixes that by passing npm package name instead of passing id directly.
Additional context
internal discord thread
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).