Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dev): inject register not working when disabling web manifest #686

Merged
merged 2 commits into from
Mar 15, 2024
Merged

fix(dev): inject register not working when disabling web manifest #686

merged 2 commits into from
Mar 15, 2024

Conversation

userquin
Copy link
Member

closes #660

@netlify Netlify
Copy link

netlify bot commented Mar 15, 2024 •
edited
Loading

✅ Deploy Preview for vite-plugin-pwa-legacy ready!

Name Link
🔨 Latest commit a2a68ab
🔍 Latest deploy log https://app.netlify.com/sites/vite-plugin-pwa-legacy/deploys/65f44e7cf4c83e00087024d2
😎 Deploy Preview https://deploy-preview-686--vite-plugin-pwa-legacy.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rschristian
Copy link

Gave this a quick test but it doesn't seem to correct the issue, unless I'm being daft (perfectly possible).

@userquin
Copy link
Member Author

Gave this a quick test but it doesn't seem to correct the issue, unless I'm being daft (perfectly possible).

I'm preparing some tests in my local, will take some time...

@rschristian
Copy link

No worries or rush! Just thought I'd comment that

@userquin
Copy link
Member Author

I need to change also the transformIndexHtml in the dev plugin

@userquin
Copy link
Member Author

No worries or rush! Just thought I'd comment that

With last commit should work: tested with vanilla-ts-dev-options example.

@userquin userquin merged commit 293db14 into main Mar 15, 2024
4 checks passed
@userquin userquin deleted the userquin/fix-inject-register-dev-without-manifest branch March 15, 2024 13:42
renovate bot referenced this pull request in SebastianGoeb/chinese-chart Mar 18, 2024
@renovate
chore(deps): update dependency vite-plugin-pwa to v0.19.4 (#134)
200577a 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [vite-plugin-pwa](https://togithub.com/vite-pwa/vite-plugin-pwa) |
[`0.19.2` ->
`0.19.4`](https://renovatebot.com/diffs/npm/vite-plugin-pwa/0.19.2/0.19.4)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/vite-plugin-pwa/0.19.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/vite-plugin-pwa/0.19.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/vite-plugin-pwa/0.19.2/0.19.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/vite-plugin-pwa/0.19.2/0.19.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>vite-pwa/vite-plugin-pwa (vite-plugin-pwa)</summary>

###
[`v0.19.4`](https://togithub.com/vite-pwa/vite-plugin-pwa/releases/tag/v0.19.4)

[Compare
Source](https://togithub.com/vite-pwa/vite-plugin-pwa/compare/v0.19.3...v0.19.4)

#####    🐞 Bug Fixes

- **dev**: Inject register not working when disabling web manifest  - 
by [@&#8203;userquin](https://togithub.com/userquin) in
[https://github.com/vite-pwa/vite-plugin-pwa/issues/686](https://togithub.com/vite-pwa/vite-plugin-pwa/issues/686)
[<samp>(293db)</samp>](https://togithub.com/vite-pwa/vite-plugin-pwa/commit/293db14)

#####     [View changes on
GitHub](https://togithub.com/vite-pwa/vite-plugin-pwa/compare/v0.19.3...v0.19.4)

###
[`v0.19.3`](https://togithub.com/vite-pwa/vite-plugin-pwa/releases/tag/v0.19.3)

[Compare
Source](https://togithub.com/vite-pwa/vite-plugin-pwa/compare/v0.19.2...v0.19.3)

#####    🐞 Bug Fixes

- Pwa assets disabled when using inlined configuration  -  by
[@&#8203;userquin](https://togithub.com/userquin) in
[https://github.com/vite-pwa/vite-plugin-pwa/issues/685](https://togithub.com/vite-pwa/vite-plugin-pwa/issues/685)
[<samp>(7ffeb)</samp>](https://togithub.com/vite-pwa/vite-plugin-pwa/commit/7ffeb44)

#####     [View changes on
GitHub](https://togithub.com/vite-pwa/vite-plugin-pwa/compare/v0.19.2...v0.19.3)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 4am on Monday" (UTC),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/SebastianGoeb/chinese-chart).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNDUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjI0NS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This was referenced May 28, 2024
Open
Merged
This was referenced Jun 19, 2024
Open
Open
Open
@patooworld patooworld mentioned this pull request Jun 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

InjectRegister not working when disabling manifest
2 participants
@userquin @rschristian