feat: update type definitions for manifest options
#573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vite-plugin-pwa-legacy ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
skyclouds2001
changed the title
manifest option
skyclouds2001
changed the title
manifest optionmanifest option
skyclouds2001
changed the title
manifest optionmanifest option
|
@skyclouds2001 thx a lot, can you add the links in the corresponding jsdocs entry using Can you also extract icon type/interface, it is duplicated in a few places? |
Done |
userquin
changed the title
manifest optionmanifest options
|
@skyclouds2001 I need to change the icon purpose adding the logic to convert it to string when using array in icons and shortcuts EDIT: if you check any vite config file in the examples folder, |
userquin
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some updates to
manifestoptioniconsmemberhttps://developer.mozilla.org/en-US/docs/Web/Manifest/icons
https://w3c.github.io/manifest/#icons-member
https://w3c.github.io/manifest/#manifest-image-resources
displaymemberhttps://developer.mozilla.org/en-US/docs/Web/Manifest/display
https://w3c.github.io/manifest/#display-member
display_overridememberhttps://developer.mozilla.org/en-US/docs/Web/Manifest/display_override
https://wicg.github.io/manifest-incubations/#display_override-member
file_handlersmemberhttps://developer.mozilla.org/en-US/docs/Web/Manifest/file_handlers
https://wicg.github.io/manifest-incubations/#file_handlers-member
shortcuts.iconsmemberhttps://developer.mozilla.org/en-US/docs/Web/Manifest/shortcuts
https://w3c.github.io/manifest/#shortcuts-member
share_targetmemberhttps://developer.mozilla.org/en-US/docs/Web/Manifest/share_target
https://w3c.github.io/web-share-target/level-2/#share_target-member