feat: use webManifestUrl on injectDevManifest
#300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I forgot to use `webManifestUrl` also on `injectDevManifest`: if someone using it will not work (`SvelteKit` will not fail since the `manifest.webmanifest` is included on the `_layout`)
✅ Deploy Preview for vite-plugin-pwa ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
I need to add the content type when serving it, I'll fix it. |
Closed
antfu
reviewed
Jun 7, 2022
| const { filePaths } = await generateServiceWorker( | ||
| Object.assign( | ||
| {}, | ||
| options, | ||
| { | ||
| workbox: { | ||
| ...options.workbox, | ||
| navigateFallbackDenylist: [new RegExp(`^${webManifestUrl}$`)], |
There was a problem hiding this comment.
no, using the constructor will replace with the escaped literal: /manifest.webmanifest => ^\/manifest.webmanifest$.
I check it.
There was a problem hiding this comment.
wait, I can double check...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot to use
webManifestUrlalso oninjectDevManifest: if someone using it will not work (SvelteKitwill not fail since themanifest.webmanifestis included on the_layout)