AddUser and password

[franiis]

Hi,

I think that now it's impossible to create user with addUser API's Method.
If you look into DataServiceImpl code, there is if which requires login and password to create user (from User.java model).
But User.java's password has JsonIgnore annotation.

So when I send request to AddUser with password, model doesn't use that field and throws exception on mentioned "if". It can be solved by deleting this annotation (methods works then), but IMO it's bad solution (unsafe).

Is there different method to use this method and I'm doing something incorrect?

Greetings
Piotr - franiis

[vitalidze]

To add user you can call 'register' method. As for the solution for addUser method I believe the @JsonIgnore@ annotation can be put on thegetPassword()method only so the user entity won't be transferred with password. But then it will require to make some changes inupdateUsermethod so it will ignore users withnull` passwords.

[franiis]

Thank you for answer.
I can do (more or less) the same thing with register (I don't know Traccar good enough to determine for example value managedBy_id column) and adding @JsonIgnore to getPassword (without further changes) doesn't solve it (I tried it).
I just tried to report slightly broken API method :)

[vitalidze]

Fixed, written news, updated latest and demo versions.